Separate normal task review from AQMM review
This commit is contained in:
@@ -15,7 +15,7 @@ from app.modules.manager_dashboard.service import (
|
||||
get_manager_review_workspace,
|
||||
get_next_manager_review_task_id,
|
||||
)
|
||||
from app.modules.services.execution import apply_task_review
|
||||
from app.modules.services.execution import apply_normal_task_review, apply_task_review
|
||||
from app.modules.alerts.workflow_escalations import update_workflow_escalation
|
||||
|
||||
router = APIRouter(prefix="/manager", tags=["manager-dashboard-v2-ui"])
|
||||
@@ -160,14 +160,23 @@ def manager_review_task_submit(
|
||||
if not task:
|
||||
return RedirectResponse(url="/manager/dashboard?tab=review-queue", status_code=303)
|
||||
try:
|
||||
apply_task_review(
|
||||
db,
|
||||
task=task,
|
||||
review_level="manager",
|
||||
decision=decision,
|
||||
note=review_note,
|
||||
user_id=current_user.id,
|
||||
)
|
||||
if active.get("review_kind") == "normal":
|
||||
apply_normal_task_review(
|
||||
db,
|
||||
task=task,
|
||||
decision=decision,
|
||||
note=review_note,
|
||||
user_id=current_user.id,
|
||||
)
|
||||
else:
|
||||
apply_task_review(
|
||||
db,
|
||||
task=task,
|
||||
review_level="manager",
|
||||
decision=decision,
|
||||
note=review_note,
|
||||
user_id=current_user.id,
|
||||
)
|
||||
db.commit()
|
||||
except ValueError:
|
||||
db.rollback()
|
||||
|
||||
Reference in New Issue
Block a user