Add Phase 22 master integrity engine
This commit is contained in:
A R R R Associates
@@ -0,0 +1,309 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import re
|
||||
from collections import defaultdict
|
||||
from difflib import SequenceMatcher
|
||||
from typing import Any
|
||||
|
||||
from sqlalchemy import select
|
||||
|
||||
from app.modules.accounting.chart_models import AccountingChartGroup, AccountingChartLedger
|
||||
from app.modules.accounting.chart_service import ROLE_LABELS, effective_role
|
||||
from app.modules.accounting.stock_models import AccountingStockGroup, AccountingStockItem, AccountingStockUnit
|
||||
from app.modules.accounting.stock_service import normalize_unit
|
||||
|
||||
|
||||
def _s(value: Any) -> str:
|
||||
return str(value or "").strip()
|
||||
|
||||
|
||||
def _key(value: Any) -> str:
|
||||
return re.sub(r"[^a-z0-9]+", " ", _s(value).casefold()).strip()
|
||||
|
||||
|
||||
def _compact(value: Any) -> str:
|
||||
return re.sub(r"[^a-z0-9]+", "", _s(value).casefold())
|
||||
|
||||
|
||||
def _payload(value: str) -> dict:
|
||||
try:
|
||||
data = json.loads(value or "{}")
|
||||
return data if isinstance(data, dict) else {}
|
||||
except Exception:
|
||||
return {}
|
||||
|
||||
|
||||
ROLE_EXPECTED_ROOTS = {
|
||||
"CUSTOMER": {"sundry debtors"},
|
||||
"SUPPLIER": {"sundry creditors"},
|
||||
"SALES": {"sales accounts"},
|
||||
"PURCHASE": {"purchase accounts"},
|
||||
"DIRECT_INCOME": {"direct incomes"},
|
||||
"OTHER_INCOME": {"indirect incomes"},
|
||||
"DIRECT_EXPENSE": {"direct expenses"},
|
||||
"INDIRECT_EXPENSE": {"indirect expenses"},
|
||||
"BANK": {"bank accounts"},
|
||||
"CASH": {"cash in hand"},
|
||||
"FIXED_ASSET": {"fixed assets"},
|
||||
"CURRENT_ASSET": {"current assets"},
|
||||
"CURRENT_LIABILITY": {"current liabilities"},
|
||||
"LOAN": {"loans liability", "secured loans", "unsecured loans", "bank od a c"},
|
||||
"CAPITAL": {"capital account"},
|
||||
"RESERVE": {"reserves surplus"},
|
||||
"INVENTORY": {"stock in hand"},
|
||||
"INVESTMENT": {"investments"},
|
||||
"GST_INPUT": {"duties taxes"},
|
||||
"GST_OUTPUT": {"duties taxes"},
|
||||
"TAX_OTHER": {"duties taxes"},
|
||||
"INTER_BRANCH": {"branch divisions"},
|
||||
"SUSPENSE": {"suspense a c"},
|
||||
}
|
||||
|
||||
|
||||
def _issue(kind: str, severity: str, master_type: str, name: str, current: str, suggested: str,
|
||||
reason: str, *, master_id: int | None = None, related: str = "") -> dict:
|
||||
return {
|
||||
"kind": kind,
|
||||
"severity": severity,
|
||||
"master_type": master_type,
|
||||
"master_id": master_id,
|
||||
"name": name,
|
||||
"current": current,
|
||||
"suggested": suggested,
|
||||
"reason": reason,
|
||||
"related": related,
|
||||
}
|
||||
|
||||
|
||||
def _duplicate_pairs(rows, name_getter, threshold: float = 0.94):
|
||||
buckets: dict[str, list] = defaultdict(list)
|
||||
for row in rows:
|
||||
key = _compact(name_getter(row))
|
||||
if key:
|
||||
buckets[key[:1]].append(row)
|
||||
|
||||
pairs = []
|
||||
seen = set()
|
||||
for bucket in buckets.values():
|
||||
for i, left in enumerate(bucket):
|
||||
lk = _compact(name_getter(left))
|
||||
if len(lk) < 4:
|
||||
continue
|
||||
for right in bucket[i + 1:]:
|
||||
rk = _compact(name_getter(right))
|
||||
if len(rk) < 4:
|
||||
continue
|
||||
pair_key = tuple(sorted((int(left.id), int(right.id))))
|
||||
if pair_key in seen:
|
||||
continue
|
||||
seen.add(pair_key)
|
||||
if lk == rk:
|
||||
score = 1.0
|
||||
elif abs(len(lk) - len(rk)) > max(4, int(max(len(lk), len(rk)) * 0.20)):
|
||||
continue
|
||||
else:
|
||||
score = SequenceMatcher(None, lk, rk).ratio()
|
||||
if score >= threshold:
|
||||
pairs.append((left, right, score))
|
||||
return pairs
|
||||
|
||||
|
||||
def build_master_integrity_report(db, *, tenant_id: int, client_id: int, tally_guid: str) -> dict:
|
||||
filters = (
|
||||
lambda model: (
|
||||
model.tenant_id == int(tenant_id),
|
||||
model.client_id == int(client_id),
|
||||
model.tally_guid == _s(tally_guid),
|
||||
)
|
||||
)
|
||||
|
||||
groups = list(db.execute(select(AccountingChartGroup).where(*filters(AccountingChartGroup))).scalars().all())
|
||||
ledgers = list(db.execute(select(AccountingChartLedger).where(*filters(AccountingChartLedger))).scalars().all())
|
||||
stock_groups = list(db.execute(select(AccountingStockGroup).where(*filters(AccountingStockGroup))).scalars().all())
|
||||
stock_items = list(db.execute(select(AccountingStockItem).where(*filters(AccountingStockItem))).scalars().all())
|
||||
units = list(db.execute(select(AccountingStockUnit).where(*filters(AccountingStockUnit))).scalars().all())
|
||||
|
||||
issues: list[dict] = []
|
||||
|
||||
group_names = {_key(row.name) for row in groups}
|
||||
stock_group_names = {_key(row.name) for row in stock_groups}
|
||||
unit_names = {_key(row.name) for row in units}
|
||||
|
||||
# Ledger parent integrity + accounting-role/root-group consistency.
|
||||
for row in ledgers:
|
||||
parent_key = _key(row.parent_group_name)
|
||||
root_key = _key(row.root_group_name)
|
||||
if row.parent_group_name and parent_key not in group_names:
|
||||
issues.append(_issue(
|
||||
"MISSING_LEDGER_PARENT", "high", "Ledger", row.name,
|
||||
row.parent_group_name, "Review / sync Tally group",
|
||||
"Ledger refers to a parent group that is not present in the synced Chart of Accounts.",
|
||||
master_id=row.id,
|
||||
))
|
||||
|
||||
role = effective_role(row)
|
||||
expected = ROLE_EXPECTED_ROOTS.get(role, set())
|
||||
if expected and root_key and root_key not in expected:
|
||||
issues.append(_issue(
|
||||
"LEDGER_GROUP_MISMATCH", "high", "Ledger", row.name,
|
||||
row.root_group_name or row.parent_group_name,
|
||||
" / ".join(sorted(expected)),
|
||||
f"Effective role is {ROLE_LABELS.get(role, role)}, but the ledger is under a different Tally root group.",
|
||||
master_id=row.id,
|
||||
))
|
||||
|
||||
# Party master integrity.
|
||||
gstin = _compact(row.party_gstin).upper()
|
||||
if gstin and len(gstin) != 15:
|
||||
issues.append(_issue(
|
||||
"PARTY_GSTIN_LENGTH", "high", "Ledger", row.name,
|
||||
row.party_gstin, "15-character GSTIN",
|
||||
"Party GSTIN is present but is not 15 characters.",
|
||||
master_id=row.id,
|
||||
))
|
||||
if role in {"CUSTOMER", "SUPPLIER"} and _s(row.gst_registration_type) and not gstin:
|
||||
reg = _key(row.gst_registration_type)
|
||||
if any(x in reg for x in ("regular", "composition", "consumer", "registered")) and "unregistered" not in reg:
|
||||
issues.append(_issue(
|
||||
"REGISTERED_PARTY_WITHOUT_GSTIN", "medium", "Ledger", row.name,
|
||||
row.gst_registration_type, "Verify GSTIN / registration type",
|
||||
"Party appears to carry a GST registration classification but no GSTIN is stored in the synced master.",
|
||||
master_id=row.id,
|
||||
))
|
||||
|
||||
# Tax ledger sanity.
|
||||
if role in {"GST_INPUT", "GST_OUTPUT", "TAX_OTHER"}:
|
||||
tax_text = " ".join((_key(row.tax_type), _key(row.gst_applicable), _key(row.name)))
|
||||
if "gst" not in tax_text and role in {"GST_INPUT", "GST_OUTPUT"}:
|
||||
issues.append(_issue(
|
||||
"GST_LEDGER_METADATA", "medium", "Ledger", row.name,
|
||||
row.tax_type or row.gst_applicable or "Blank",
|
||||
"Verify GST tax metadata",
|
||||
"Ledger is classified as GST input/output but synced Tally GST/tax metadata does not clearly identify GST.",
|
||||
master_id=row.id,
|
||||
))
|
||||
|
||||
# Exact/near duplicate ledgers.
|
||||
for left, right, score in _duplicate_pairs(ledgers, lambda x: x.name):
|
||||
issues.append(_issue(
|
||||
"POSSIBLE_DUPLICATE_LEDGER", "medium" if score < 0.995 else "high",
|
||||
"Ledger", left.name, left.parent_group_name,
|
||||
"Review duplicate / naming",
|
||||
f"Name is {score * 100:.0f}% similar to another ledger.",
|
||||
master_id=left.id, related=right.name,
|
||||
))
|
||||
|
||||
# Stock master integrity.
|
||||
for row in stock_items:
|
||||
if row.parent_group_name and _key(row.parent_group_name) not in stock_group_names:
|
||||
issues.append(_issue(
|
||||
"MISSING_STOCK_GROUP", "high", "Stock Item", row.name,
|
||||
row.parent_group_name, "Review / sync stock group",
|
||||
"Stock item refers to a parent Stock Group that is not present in the synced master snapshot.",
|
||||
master_id=row.id,
|
||||
))
|
||||
if row.base_units and _key(row.base_units) not in unit_names:
|
||||
issues.append(_issue(
|
||||
"MISSING_STOCK_UNIT", "high", "Stock Item", row.name,
|
||||
row.base_units, "Create / correct Unit",
|
||||
"Stock item's base unit is not present in the synced Tally Unit master.",
|
||||
master_id=row.id,
|
||||
))
|
||||
if row.additional_units and _key(row.additional_units) not in unit_names:
|
||||
issues.append(_issue(
|
||||
"MISSING_ADDITIONAL_UNIT", "medium", "Stock Item", row.name,
|
||||
row.additional_units, "Create / correct Unit",
|
||||
"Stock item's additional unit is not present in the synced Tally Unit master.",
|
||||
master_id=row.id,
|
||||
))
|
||||
|
||||
gst_app = _key(row.gst_applicable)
|
||||
if gst_app and gst_app not in {"not applicable", "none", "no"} and not _s(row.hsn_code):
|
||||
issues.append(_issue(
|
||||
"GST_STOCK_WITHOUT_HSN", "medium", "Stock Item", row.name,
|
||||
row.gst_applicable, "Review HSN/SAC",
|
||||
"GST is applicable to the stock item but no HSN/SAC code is present in the synced master.",
|
||||
master_id=row.id,
|
||||
))
|
||||
|
||||
for left, right, score in _duplicate_pairs(stock_items, lambda x: x.name):
|
||||
issues.append(_issue(
|
||||
"POSSIBLE_DUPLICATE_STOCK_ITEM", "medium" if score < 0.995 else "high",
|
||||
"Stock Item", left.name, left.parent_group_name,
|
||||
"Review duplicate / naming",
|
||||
f"Name is {score * 100:.0f}% similar to another stock item.",
|
||||
master_id=left.id, related=right.name,
|
||||
))
|
||||
|
||||
# Unit aliases which are operationally equivalent but separately maintained.
|
||||
normalized_units: dict[str, list] = defaultdict(list)
|
||||
for row in units:
|
||||
normalized_units[normalize_unit(row.name)].append(row)
|
||||
for norm, rows in normalized_units.items():
|
||||
if norm and len(rows) > 1:
|
||||
names = sorted({_s(r.name) for r in rows}, key=str.casefold)
|
||||
if len(names) > 1:
|
||||
issues.append(_issue(
|
||||
"DUPLICATE_UNIT_ALIAS", "medium", "Unit",
|
||||
names[0], ", ".join(names), norm,
|
||||
"Multiple Tally units normalize to the same accounting unit and may cause stock-item mapping inconsistencies.",
|
||||
related=", ".join(names[1:]),
|
||||
))
|
||||
|
||||
severity_rank = {"high": 0, "medium": 1, "low": 2}
|
||||
issues.sort(key=lambda x: (severity_rank.get(x["severity"], 9), x["master_type"], x["name"].casefold(), x["kind"]))
|
||||
|
||||
summary = {
|
||||
"groups": len(groups),
|
||||
"ledgers": len(ledgers),
|
||||
"stock_groups": len(stock_groups),
|
||||
"stock_items": len(stock_items),
|
||||
"units": len(units),
|
||||
"issues": len(issues),
|
||||
"high": sum(1 for x in issues if x["severity"] == "high"),
|
||||
"medium": sum(1 for x in issues if x["severity"] == "medium"),
|
||||
"low": sum(1 for x in issues if x["severity"] == "low"),
|
||||
}
|
||||
issue_types = sorted({x["kind"] for x in issues})
|
||||
master_types = sorted({x["master_type"] for x in issues})
|
||||
|
||||
return {
|
||||
"summary": summary,
|
||||
"issues": issues,
|
||||
"issue_types": issue_types,
|
||||
"master_types": master_types,
|
||||
}
|
||||
|
||||
|
||||
def filter_integrity_issues(report: dict, *, q: str = "", severity: str = "", master_type: str = "",
|
||||
issue_type: str = "", page: int = 1, per_page: int = 50) -> dict:
|
||||
rows = list(report.get("issues") or [])
|
||||
qk = _key(q)
|
||||
if qk:
|
||||
rows = [
|
||||
row for row in rows
|
||||
if qk in _key(" ".join([
|
||||
row.get("name", ""), row.get("current", ""), row.get("suggested", ""),
|
||||
row.get("reason", ""), row.get("related", ""), row.get("kind", ""),
|
||||
]))
|
||||
]
|
||||
if severity:
|
||||
rows = [row for row in rows if row.get("severity") == severity]
|
||||
if master_type:
|
||||
rows = [row for row in rows if row.get("master_type") == master_type]
|
||||
if issue_type:
|
||||
rows = [row for row in rows if row.get("kind") == issue_type]
|
||||
|
||||
per_page = max(10, min(int(per_page or 50), 200))
|
||||
total = len(rows)
|
||||
pages = max(1, (total + per_page - 1) // per_page)
|
||||
page = max(1, min(int(page or 1), pages))
|
||||
start = (page - 1) * per_page
|
||||
return {
|
||||
"rows": rows[start:start + per_page],
|
||||
"total": total,
|
||||
"page": page,
|
||||
"pages": pages,
|
||||
"per_page": per_page,
|
||||
}
|
||||
@@ -0,0 +1,102 @@
|
||||
from __future__ import annotations
|
||||
|
||||
from fastapi import APIRouter, Request
|
||||
from fastapi.responses import RedirectResponse
|
||||
|
||||
from app.core.db.common import CommonSessionLocal
|
||||
from app.core.templating import templates
|
||||
from app.modules.accounting.master_integrity_service import build_master_integrity_report, filter_integrity_issues
|
||||
from app.modules.accounting.ui import _require_partner, _visible_clients
|
||||
from app.modules.core.rbac.deps import get_user_permissions, get_user_roles
|
||||
|
||||
router = APIRouter(
|
||||
prefix="/tools/accounting/master-integrity",
|
||||
tags=["accounting-master-integrity-ui"],
|
||||
)
|
||||
|
||||
|
||||
@router.get("")
|
||||
def page(
|
||||
request: Request,
|
||||
client_id: int | None = None,
|
||||
tally_guid: str = "",
|
||||
q: str = "",
|
||||
severity: str = "",
|
||||
master_type: str = "",
|
||||
issue_type: str = "",
|
||||
page: int = 1,
|
||||
per_page: int = 50,
|
||||
):
|
||||
db = CommonSessionLocal()
|
||||
try:
|
||||
user, denied = _require_partner(request, db, "accounting.tally.view")
|
||||
if denied:
|
||||
return denied
|
||||
|
||||
clients, scope = _visible_clients(db, request, user)
|
||||
selected = next((c for c in clients if client_id and int(c.id) == int(client_id)), None)
|
||||
|
||||
# This phase intentionally analyzes the already-synced ERP master snapshots.
|
||||
# Tally writes are not performed from this report.
|
||||
report = {
|
||||
"summary": {"groups": 0, "ledgers": 0, "stock_groups": 0, "stock_items": 0, "units": 0,
|
||||
"issues": 0, "high": 0, "medium": 0, "low": 0},
|
||||
"issues": [], "issue_types": [], "master_types": [],
|
||||
}
|
||||
filtered = {"rows": [], "total": 0, "page": 1, "pages": 1, "per_page": per_page}
|
||||
available_guids = []
|
||||
|
||||
if selected:
|
||||
from sqlalchemy import select
|
||||
from app.modules.accounting.chart_models import AccountingChartLedger
|
||||
available_guids = [
|
||||
row[0] for row in db.execute(
|
||||
select(AccountingChartLedger.tally_guid)
|
||||
.where(
|
||||
AccountingChartLedger.tenant_id == scope.tenant_id,
|
||||
AccountingChartLedger.client_id == selected.id,
|
||||
)
|
||||
.distinct()
|
||||
.order_by(AccountingChartLedger.tally_guid)
|
||||
).all()
|
||||
if str(row[0] or "").strip()
|
||||
]
|
||||
if tally_guid and tally_guid not in available_guids:
|
||||
tally_guid = ""
|
||||
if not tally_guid and len(available_guids) == 1:
|
||||
tally_guid = available_guids[0]
|
||||
|
||||
if tally_guid:
|
||||
report = build_master_integrity_report(
|
||||
db,
|
||||
tenant_id=scope.tenant_id,
|
||||
client_id=selected.id,
|
||||
tally_guid=tally_guid,
|
||||
)
|
||||
filtered = filter_integrity_issues(
|
||||
report, q=q, severity=severity, master_type=master_type,
|
||||
issue_type=issue_type, page=page, per_page=per_page,
|
||||
)
|
||||
|
||||
return templates.TemplateResponse(
|
||||
"modules/accounting/templates/accounting/master_integrity.html",
|
||||
{
|
||||
"request": request,
|
||||
"current_user": user,
|
||||
"current_user_roles": get_user_roles(db, user.id),
|
||||
"current_user_permissions": get_user_permissions(db, user.id),
|
||||
"title": "Master Integrity Engine",
|
||||
"clients": clients,
|
||||
"selected_client": selected,
|
||||
"available_guids": available_guids,
|
||||
"selected_tally_guid": tally_guid,
|
||||
"report": report,
|
||||
"filtered": filtered,
|
||||
"q": q,
|
||||
"severity_filter": severity,
|
||||
"master_type_filter": master_type,
|
||||
"issue_type_filter": issue_type,
|
||||
},
|
||||
)
|
||||
finally:
|
||||
db.close()
|
||||
@@ -0,0 +1,120 @@
|
||||
{% extends "ui/templates/base/layout.html" %}
|
||||
{% block content %}
|
||||
<div class="space-y-6">
|
||||
<div class="flex flex-wrap items-start justify-between gap-3">
|
||||
<div>
|
||||
<p class="text-xs font-semibold uppercase tracking-[0.16em] text-brand-600">Tools · Accounting · Phase 22</p>
|
||||
<h1 class="mt-1 text-2xl font-semibold text-slate-900">Chart of Accounts / Master Integrity Engine</h1>
|
||||
<p class="mt-1 max-w-4xl text-sm text-slate-500">Accounting + audit control over synced Tally Groups, Ledgers, Stock Groups, Stock Items and Units. This phase identifies master inconsistencies and routes corrections through the existing controlled tools; it does not silently alter Tally masters.</p>
|
||||
</div>
|
||||
<div class="flex flex-wrap gap-2">
|
||||
<a href="/tools/accounting" class="rounded-xl border border-slate-300 bg-white px-3 py-2 text-sm font-semibold text-slate-700">Back to Accounting</a>
|
||||
{% if selected_client %}
|
||||
<a href="/tools/accounting/chart-of-accounts?client_id={{ selected_client.id }}{% if selected_tally_guid %}&tally_guid={{ selected_tally_guid }}{% endif %}" class="rounded-xl border border-blue-300 bg-blue-50 px-3 py-2 text-sm font-semibold text-blue-800">Open Chart of Accounts</a>
|
||||
<a href="/tools/accounting/stock-items?client_id={{ selected_client.id }}{% if selected_tally_guid %}&tally_guid={{ selected_tally_guid }}{% endif %}" class="rounded-xl border border-indigo-300 bg-indigo-50 px-3 py-2 text-sm font-semibold text-indigo-800">Open Stock Intelligence</a>
|
||||
{% endif %}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<form method="get" action="/tools/accounting/master-integrity" class="rounded-2xl border border-slate-200 bg-white p-4 shadow-soft">
|
||||
<div class="grid gap-3 md:grid-cols-2 xl:grid-cols-6">
|
||||
<select name="client_id" class="rounded-xl border border-slate-300 px-3 py-2 text-sm" onchange="this.form.submit()">
|
||||
<option value="">Select client</option>
|
||||
{% for client in clients %}<option value="{{ client.id }}" {% if selected_client and selected_client.id==client.id %}selected{% endif %}>{{ client.client_name }}</option>{% endfor %}
|
||||
</select>
|
||||
<select name="tally_guid" class="rounded-xl border border-slate-300 px-3 py-2 text-sm" onchange="this.form.submit()">
|
||||
<option value="">Select synced Tally company</option>
|
||||
{% for guid in available_guids %}<option value="{{ guid }}" {% if selected_tally_guid==guid %}selected{% endif %}>{{ guid }}</option>{% endfor %}
|
||||
</select>
|
||||
<input name="q" value="{{ q }}" placeholder="Search issue/master..." class="rounded-xl border border-slate-300 px-3 py-2 text-sm">
|
||||
<select name="severity" class="rounded-xl border border-slate-300 px-3 py-2 text-sm">
|
||||
<option value="">All severities</option>
|
||||
{% for value in ['high','medium','low'] %}<option value="{{ value }}" {% if severity_filter==value %}selected{% endif %}>{{ value|title }}</option>{% endfor %}
|
||||
</select>
|
||||
<select name="master_type" class="rounded-xl border border-slate-300 px-3 py-2 text-sm">
|
||||
<option value="">All master types</option>
|
||||
{% for value in report.master_types %}<option value="{{ value }}" {% if master_type_filter==value %}selected{% endif %}>{{ value }}</option>{% endfor %}
|
||||
</select>
|
||||
<div class="flex gap-2">
|
||||
<button class="flex-1 rounded-xl bg-slate-900 px-3 py-2 text-sm font-semibold text-white">Apply</button>
|
||||
<a href="/tools/accounting/master-integrity{% if selected_client %}?client_id={{ selected_client.id }}{% endif %}" class="rounded-xl border border-slate-300 px-3 py-2 text-sm">Clear</a>
|
||||
</div>
|
||||
</div>
|
||||
{% if report.issue_types %}
|
||||
<div class="mt-3">
|
||||
<select name="issue_type" class="w-full rounded-xl border border-slate-300 px-3 py-2 text-sm">
|
||||
<option value="">All integrity checks</option>
|
||||
{% for value in report.issue_types %}<option value="{{ value }}" {% if issue_type_filter==value %}selected{% endif %}>{{ value|replace('_',' ')|title }}</option>{% endfor %}
|
||||
</select>
|
||||
</div>
|
||||
{% endif %}
|
||||
</form>
|
||||
|
||||
{% if selected_client and selected_tally_guid %}
|
||||
<div class="grid gap-3 sm:grid-cols-2 xl:grid-cols-5">
|
||||
<div class="rounded-2xl bg-white p-4 shadow-soft"><div class="text-xs text-slate-500">Ledgers checked</div><div class="mt-1 text-2xl font-semibold">{{ report.summary.ledgers }}</div></div>
|
||||
<div class="rounded-2xl bg-white p-4 shadow-soft"><div class="text-xs text-slate-500">Stock items checked</div><div class="mt-1 text-2xl font-semibold">{{ report.summary.stock_items }}</div></div>
|
||||
<div class="rounded-2xl bg-white p-4 shadow-soft"><div class="text-xs text-slate-500">High priority</div><div class="mt-1 text-2xl font-semibold text-rose-700">{{ report.summary.high }}</div></div>
|
||||
<div class="rounded-2xl bg-white p-4 shadow-soft"><div class="text-xs text-slate-500">Medium priority</div><div class="mt-1 text-2xl font-semibold text-amber-700">{{ report.summary.medium }}</div></div>
|
||||
<div class="rounded-2xl bg-white p-4 shadow-soft"><div class="text-xs text-slate-500">Total exceptions</div><div class="mt-1 text-2xl font-semibold">{{ report.summary.issues }}</div></div>
|
||||
</div>
|
||||
|
||||
<section class="overflow-hidden rounded-2xl bg-white shadow-soft">
|
||||
<div class="flex flex-wrap items-center justify-between gap-2 border-b border-slate-200 p-4">
|
||||
<div>
|
||||
<h2 class="font-semibold text-slate-900">Exceptions requiring review</h2>
|
||||
<p class="text-xs text-slate-500">Showing {{ filtered.total }} matching exception{{ '' if filtered.total==1 else 's' }}. Existing master tools remain the correction authority.</p>
|
||||
</div>
|
||||
<div class="text-xs text-slate-500">Groups {{ report.summary.groups }} · Stock Groups {{ report.summary.stock_groups }} · Units {{ report.summary.units }}</div>
|
||||
</div>
|
||||
<div class="overflow-x-auto">
|
||||
<table class="min-w-full text-sm">
|
||||
<thead class="bg-slate-50 text-left text-xs uppercase tracking-wide text-slate-500">
|
||||
<tr><th class="px-4 py-3">Priority</th><th class="px-4 py-3">Master</th><th class="px-4 py-3">Issue</th><th class="px-4 py-3">Current</th><th class="px-4 py-3">Suggested review</th><th class="px-4 py-3">Reason</th><th class="px-4 py-3">Action</th></tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{% for row in filtered.rows %}
|
||||
<tr class="border-t border-slate-100 align-top">
|
||||
<td class="px-4 py-3"><span class="rounded-full px-2 py-1 text-xs font-semibold {% if row.severity=='high' %}bg-rose-100 text-rose-800{% elif row.severity=='medium' %}bg-amber-100 text-amber-800{% else %}bg-slate-100 text-slate-700{% endif %}">{{ row.severity|title }}</span></td>
|
||||
<td class="px-4 py-3"><div class="font-semibold text-slate-900">{{ row.name }}</div><div class="text-xs text-slate-500">{{ row.master_type }}{% if row.related %} · Related: {{ row.related }}{% endif %}</div></td>
|
||||
<td class="px-4 py-3 text-xs font-semibold text-slate-700">{{ row.kind|replace('_',' ')|title }}</td>
|
||||
<td class="px-4 py-3 text-slate-600">{{ row.current or '—' }}</td>
|
||||
<td class="px-4 py-3 text-slate-700">{{ row.suggested or 'Review' }}</td>
|
||||
<td class="max-w-md px-4 py-3 text-slate-600">{{ row.reason }}</td>
|
||||
<td class="px-4 py-3">
|
||||
{% if row.master_type == 'Ledger' %}
|
||||
<a href="/tools/accounting/chart-of-accounts?client_id={{ selected_client.id }}&tally_guid={{ selected_tally_guid }}&q={{ row.name|urlencode }}" class="whitespace-nowrap rounded-lg border border-blue-300 bg-blue-50 px-2.5 py-1.5 text-xs font-semibold text-blue-800">Review Ledger</a>
|
||||
{% elif row.master_type == 'Stock Item' or row.master_type == 'Unit' %}
|
||||
<a href="/tools/accounting/stock-items?client_id={{ selected_client.id }}&tally_guid={{ selected_tally_guid }}&q={{ row.name|urlencode }}" class="whitespace-nowrap rounded-lg border border-indigo-300 bg-indigo-50 px-2.5 py-1.5 text-xs font-semibold text-indigo-800">Review Stock</a>
|
||||
{% else %}
|
||||
<a href="/tools/accounting/chart-of-accounts?client_id={{ selected_client.id }}&tally_guid={{ selected_tally_guid }}&view=groups" class="whitespace-nowrap rounded-lg border border-slate-300 px-2.5 py-1.5 text-xs font-semibold text-slate-700">Review Group</a>
|
||||
{% endif %}
|
||||
</td>
|
||||
</tr>
|
||||
{% else %}
|
||||
<tr><td colspan="7" class="px-4 py-8 text-center text-slate-500">No integrity exceptions match the selected filters.</td></tr>
|
||||
{% endfor %}
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
{% if filtered.pages > 1 %}
|
||||
<div class="flex items-center justify-between border-t border-slate-200 p-4 text-sm">
|
||||
<div>Page {{ filtered.page }} of {{ filtered.pages }}</div>
|
||||
<div class="flex gap-2">
|
||||
{% if filtered.page > 1 %}<a class="rounded-lg border px-3 py-1.5" href="?client_id={{ selected_client.id }}&tally_guid={{ selected_tally_guid }}&q={{ q|urlencode }}&severity={{ severity_filter }}&master_type={{ master_type_filter|urlencode }}&issue_type={{ issue_type_filter }}&page={{ filtered.page-1 }}&per_page={{ filtered.per_page }}">Previous</a>{% endif %}
|
||||
{% if filtered.page < filtered.pages %}<a class="rounded-lg border px-3 py-1.5" href="?client_id={{ selected_client.id }}&tally_guid={{ selected_tally_guid }}&q={{ q|urlencode }}&severity={{ severity_filter }}&master_type={{ master_type_filter|urlencode }}&issue_type={{ issue_type_filter }}&page={{ filtered.page+1 }}&per_page={{ filtered.per_page }}">Next</a>{% endif %}
|
||||
</div>
|
||||
</div>
|
||||
{% endif %}
|
||||
</section>
|
||||
|
||||
<div class="rounded-2xl border border-blue-200 bg-blue-50 p-4 text-sm text-blue-900">
|
||||
<div class="font-semibold">Dual-use control</div>
|
||||
<p class="mt-1">For accounting, this identifies masters that can cause wrong voucher classification or posting. For audit, the same report becomes a master-data exception review. Phase 22 deliberately does not auto-delete, rename or regroup Tally masters.</p>
|
||||
</div>
|
||||
{% elif selected_client %}
|
||||
<div class="rounded-2xl border border-amber-200 bg-amber-50 p-4 text-sm text-amber-900">No synced Tally company is available for this client. Run the existing Chart of Accounts / Stock Item sync first.</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
{% endblock %}
|
||||
@@ -20,6 +20,7 @@
|
||||
</div>
|
||||
<div class="flex flex-wrap gap-2">
|
||||
<a href="/tools/accounting/chart-of-accounts{% if selected_client %}?client_id={{ selected_client.id }}{% endif %}" class="rounded-xl bg-blue-700 px-3 py-2 text-sm font-semibold text-white">Chart of Accounts - Groups & Ledgers</a>
|
||||
<a href="/tools/accounting/master-integrity{% if selected_client %}?client_id={{ selected_client.id }}{% endif %}" class="rounded-xl border border-rose-300 bg-white px-3 py-2 text-sm font-semibold text-rose-800">Master Integrity Engine</a>
|
||||
<a href="/tools/accounting/stock-items{% if selected_client %}?client_id={{ selected_client.id }}{% endif %}" class="rounded-xl border border-indigo-300 bg-white px-3 py-2 text-sm font-semibold text-indigo-800">Stock Item Intelligence</a>
|
||||
<a href="/tools/accounting/opening-balances{% if selected_client %}?client_id={{ selected_client.id }}{% endif %}" class="rounded-xl border border-amber-300 bg-white px-3 py-2 text-sm font-semibold text-amber-800">Opening Balance Review</a>
|
||||
<a href="/tools/accounting/voucher-engine{% if selected_client %}?client_id={{ selected_client.id }}{% endif %}" class="rounded-xl border border-blue-300 bg-white px-3 py-2 text-sm font-semibold text-blue-800">Accounting Voucher Engine</a>
|
||||
|
||||
Reference in New Issue
Block a user